Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Example: simplify_udaf_expression.rs into advanced_udaf.rs #13842

Open
Tracked by #11172
alamb opened this issue Dec 19, 2024 · 2 comments
Open
Tracked by #11172

Consolidate Example: simplify_udaf_expression.rs into advanced_udaf.rs #13842

alamb opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Dec 19, 2024

Is your feature request related to a problem or challenge?

The large number of small examples in DataFusion leads to multiple problems:

  • Unnecessarily large amounts of temporary disk space (each example binary takes 100+ MB)
  • Larger cargo t time (each binary must be linked / created)
  • Makes it harder to find the relevant examples

Thus I think the fewer examples we have the

  1. faster our dev experience will be
  2. easier it will be to find the relevant examples

Describe the solution you'd like

Then update the readme page:

Describe alternatives you've considered

No response

Additional context

I think this is a good first issue as the task is straightforward and doesn't require deep understanding of the DataFusion codebase

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2024
@alamb alamb changed the title Consolidate parquet.sql into Consolidate Example: simplify_udaf_expression.rs into advanced_udaf.rs Dec 19, 2024
@takaebato
Copy link

take

@alamb
Copy link
Contributor Author

alamb commented Dec 20, 2024

Thank you @takaebato 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants