Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking to FFI crate #13827

Open
timsaucer opened this issue Dec 18, 2024 · 1 comment
Open

Add version checking to FFI crate #13827

timsaucer opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@timsaucer
Copy link
Contributor

Is your feature request related to a problem or challenge?

This came up as part of this PR: #13823

As the FFI crate evolves we need some way to verify across the FFI boundary the version compatibility.

Describe the solution you'd like

Likely we need to add a function that is a simple version output in datafusion-ffi so that users can query across the boundary and verify the versions of the API are compatible.

Describe alternatives you've considered

None I can think of.

Additional context

No response

@alamb
Copy link
Contributor

alamb commented Dec 19, 2024

I likely don't really understand FFI yet, but I think what is needed is that the FFI bindings used match the version of DataFusion that will use the TableProvider

SO in this case if we merge #13823 prior to releaseing 0.44.0 it will mean anyone who wants to use their table provider in 0.44 via FFI will hvae to update the FFI bindings. So to use a TableProvider based on DataFusion 43 someone will have to implement the DataFusion 44 bindings by calling the DataFusion 43 provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants