Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opt_filter optional parameter in GroupsAccumulator:merge #13484

Open
alamb opened this issue Nov 19, 2024 · 0 comments
Open

Remove opt_filter optional parameter in GroupsAccumulator:merge #13484

alamb opened this issue Nov 19, 2024 · 0 comments

Comments

@alamb
Copy link
Contributor

alamb commented Nov 19, 2024

          That is why I return error for now, we can remove the `opt_filter` after couple of months

Originally posted by @jayzhan211 in #13463 (comment)

The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.

@jayzhan211s PRs above throws an error if this assumption is not true.

If we haven't hit any errors in a few months, we should just remove the parameter entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant