We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt_filter
That is why I return error for now, we can remove the `opt_filter` after couple of months
Originally posted by @jayzhan211 in #13463 (comment)
The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.
@jayzhan211s PRs above throws an error if this assumption is not true.
If we haven't hit any errors in a few months, we should just remove the parameter entirely
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Originally posted by @jayzhan211 in #13463 (comment)
The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.
@jayzhan211s PRs above throws an error if this assumption is not true.
If we haven't hit any errors in a few months, we should just remove the parameter entirely
The text was updated successfully, but these errors were encountered: