Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract(second from dt) should return seconds without fraction #13482

Closed
findepi opened this issue Nov 19, 2024 · 4 comments · Fixed by #13466
Closed

extract(second from dt) should return seconds without fraction #13482

findepi opened this issue Nov 19, 2024 · 4 comments · Fixed by #13466

Comments

@findepi
Copy link
Member

findepi commented Nov 19, 2024

In ANSI SQL, Trino, Snowflake, DuckDB, ... extract(second from a_date_time_value) returns just seconds (integer number 0-59 inclusive), which is consistent with other extraction of other fields like minute (meaning minute-of-hour), hour (meaning hour-of-day), etc. especially when sub-second fields are also supported.

in DataFusion extract(second from dt) returns second with fraction (as in PostgreSQL).
We should probably change it to return just second without fraction, especially given that the fraction part can be extracted with e.g. extract(millisecond ..) field

cc @jayzhan211 @comphead

@jayzhan211
Copy link
Contributor

jayzhan211 commented Nov 19, 2024

Given there are other systems return integer too, I'm fine if we return int for second and mili/micro/nano second

@jayzhan211
Copy link
Contributor

I found that nanosecond is neither supported in postgres and duckdb. If it is true, I prefer to remove it.

@comphead
Copy link
Contributor

I dont remember why we do support nanos although most of systems do not.
not sure if we need to remove it if it works it can probably be helpful for someone if they store and do maths exacly on nanosecond level, not sure what the real world use case could be. Perhaps scientific thing

@jayzhan211
Copy link
Contributor

I dont remember why we do support nanos although most of systems do not. not sure if we need to remove it if it works it can probably be helpful for someone if they store and do maths exacly on nanosecond level, not sure what the real world use case could be. Perhaps scientific thing

If they really need nanosecond precision, they could customize the function for themselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants