Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datafusion.execution.time_zone is not used for basic time zone inference #13212

Open
adriangb opened this issue Nov 1, 2024 · 5 comments
Open
Labels
bug Something isn't working

Comments

@adriangb
Copy link
Contributor

adriangb commented Nov 1, 2024

Describe the bug

I would expect that setting SET datafusion.execution.time_zone = '+08:00' would lead to SELECT '2024-11-01T00:00:00.0+00:00'::timestamptz - '2024-11-01T00:00:00.0'::timestamp to give 8 hours (that is, the same as SELECT '2024-11-01T00:00:00.0+00:00'::timestamptz - '2024-11-01T00:00:00.0+08:00'::timestamptz). Some things do work e.g. SELECT '2024-11-01T00:00:00.0'::timestamptz does give 2024-11-01T00:00:00+08:00.

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@adriangb adriangb added the bug Something isn't working label Nov 1, 2024
@adriangb
Copy link
Contributor Author

adriangb commented Nov 1, 2024

cc @alamb I think you've written some tests for datafusion.execution.time_zone based on blames, I couldn't track down who originally implemented it

@alamb
Copy link
Contributor

alamb commented Nov 1, 2024

Hi @adriangb -- I am not sure who originally implemented it either. I think @Omega359 was thinking about how to specify / pass the default timezones to functions recently too

@Omega359
Copy link
Contributor

Omega359 commented Nov 1, 2024

Yes, it's been on my radar for a while now. There are a number of issues around tz's some of which are generic tz issues, others are issues where using the default tz in config might be useful. A small but not complete list

@jonathanc-n
Copy link
Contributor

jonathanc-n commented Nov 1, 2024

Someone can probably take a look at #13130, it seems to be done it just has a doc check error

@alamb
Copy link
Contributor

alamb commented Nov 21, 2024

This may now be feasible after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants