Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUnit tests on windows opens a bunch of terminals then closes them #5246

Closed
nickva opened this issue Sep 17, 2024 · 2 comments
Closed

EUnit tests on windows opens a bunch of terminals then closes them #5246

nickva opened this issue Sep 17, 2024 · 2 comments
Labels

Comments

@nickva
Copy link
Contributor

nickva commented Sep 17, 2024

Both @big-r81 and I noticed when running make eunit apps=couch on Windows about a dozen terminal windows are spawned and then closed after about 10 seconds.

@big-r81 figured it out it's from opening "sleep.exe" commands. By default windows will spawn a terminal for those. We need to use the hide option in open_port to prevent it.

Port = erlang:open_port({spawn, "sleep 10"}, []),

@nickva nickva added the bug label Sep 17, 2024
@nickva
Copy link
Contributor Author

nickva commented Sep 17, 2024

While looking at that test in the couch_debug module. There is likely another issue with it, where it doesn't cleanup properly its process tree:

[exit(Pid, normal) || Pid <- Processes].

exit(Pid, normal) is a no-op effectively, so that leaves a bunch of processes around

nickva added a commit that referenced this issue Sep 17, 2024
On Windows, not specifying `hide` will pop up a terminal window. Our
JavaScript OS process port opens use `hide` as well.

Issue: #5246
nickva added a commit that referenced this issue Sep 17, 2024
On Windows, not specifying `hide` will pop up a terminal window. Our
JavaScript OS process port opens use `hide` as well.

Issue: #5246
@nickva
Copy link
Contributor Author

nickva commented Sep 24, 2024

These should be fixed now

@nickva nickva closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant