-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add Iceberg to AlloyDB Blueprint #36036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This shows how to use the AlloyDB language connector, specifically see how the jdbc_url is formatted with instance name etc. It also requires expansion service to have com.google.cloud:alloydb-jdbc-connector https://github.com/GoogleCloudPlatform/alloydb-java-connector/blob/main/docs/jdbc.md for official docs |
schema-io-expansion-service already contain required alloydb-jdbc-connector and postgres jars |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36036 +/- ##
=========================================
Coverage 56.79% 56.80%
Complexity 3385 3385
=========================================
Files 1220 1220
Lines 185122 185122
Branches 3508 3508
=========================================
+ Hits 105148 105154 +6
+ Misses 76649 76643 -6
Partials 3325 3325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Run Python_Transforms PreCommit 3.10 |
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
sdks/python/apache_beam/yaml/examples/transforms/blueprint/iceberg_to_alloydb.yaml
Outdated
Show resolved
Hide resolved
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Beam YAML blueprint demonstrating a pipeline that reads from an Apache Iceberg table and writes to an AlloyDB database. The changes include the YAML definition for the pipeline and updates to the Python test suite to include this new example. The overall implementation is good. I have one suggestion regarding the use of placeholder credentials in the example YAML file to improve security best practices.
sdks/python/apache_beam/yaml/examples/transforms/blueprint/iceberg_to_alloydb.yaml
Outdated
Show resolved
Hide resolved
Run Python_Transforms PreCommit 3.12 |
Run Python_Runners PreCommit 3.10 |
Run Python_ML PreCommit 3.11 |
Run Python_Transforms PreCommit 3.12 |
Adding Iceberg to AlloyDB blueprint
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.