#24167 Document<->Row conversion for FirestoreIO #24168
Conversation
|
Run Java PreCommit |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
| } | ||
|
|
||
| /** | ||
| * Create a random key for a {@code Row} without a keyField or use a user-specified key by |
There was a problem hiding this comment.
outdated javadoc / missing feature TBD which one
|
R: @pcostell |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
hi @nbali can you pls share when will this feature be available in master to use? I would like to use/test this functionality |
|
@vishinde Quite frankly it's not up to me at this point. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
Would be great if this could be put back on the agenda again. As far as I understand, this will also solve the issue raised here: https://stackoverflow.com/questions/71163275/add-document-to-firestore-from-beam-with-auto-generated-id |
|
Why was this not considered? It's a great addition to the current Java SDK which will make easier to work with Firestore service |
|
idk |
FirestoreIO version of https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/EntityToRow.java and https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/RowToEntity.java to avoid manual mapping of objects to the Firestore native format.
Fixes #24167
TODO:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.[ ] UpdateCHANGES.mdwith noteworthy changes.[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.