Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Release][Website] Figure out why the version banner code changed in 19.0.0 #45290

Open
amoeba opened this issue Jan 17, 2025 · 0 comments

Comments

@amoeba
Copy link
Member

amoeba commented Jan 17, 2025

After we released 19.0.0 and updated the website, I noticed the version banner wasn't set up right. Upon investigating, it looks like the post-10-docs.sh script failed to update the banner code on the stable docs and I didn't notice before merging. I captured more detail in apache/arrow-site#576.

When I grabbed the published version of the 19.0.0 docs, there was a newline that's not usually present in the version banner script:

    <script>
        DOCUMENTATION_OPTIONS.theme_version = '0.16.1';
        DOCUMENTATION_OPTIONS.theme_switcher_json_url = '/docs/_static/versions.json';
        DOCUMENTATION_OPTIONS.theme_switcher_version_match = '';
        DOCUMENTATION_OPTIONS.show_version_warning_banner =
            true; // <---- this is usually on the line above
        </script>

This caused the script's sed command to fail to replace the true with a false. If this happens again, the post-10-docs.sh script will fail so we should figure out what changed before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant