fromarrow(::Type{Dates.Time}, x::Arrow.Time)

[palday]

• closes missing methods for fromarrow(::Type{Time}, x::Arrow.Time{<:Arrow.Flatbuf.TimeUnit.T, <:Integer}) #526
• closes Error when open files with Date.Time containing MICROSECONDs #363

[ericphanson]

what is different here from

ArrowTypes.fromarrow(::Type{Dates.Date}, x::DATE) = convert(Dates.Date, x)

above? Or is that method wrong too?

[ericphanson]

ahh, I get it, we are just dropping a type parameter, TIME is Arrow.Time with a specific eltype. Ok this seems fine to me!

[palday]

That method is probably wrong too

[ericphanson]

do you want to fix that one too? Or file an issue?

[palday]

Might as well fix it too while I'm at -- I'll update it shortly

[palday]

I was unable to induce the related failure with DATE so it seems that it is not broken for reasons beyond my understanding. In other words, I think this is good to go.