fix accidental invocation of _unsafe_load_tuple (#124)

* fix accidental invocation of _unsafe_load_tuple * bump Project.toml
apache · Feb 5, 2021 · a113edd · a113edd · quinnj · Feb 5, 2021
1 parent 6c95ff6
commit a113edd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Arrow"
 uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
 authors = ["quinnj <[email protected]>"]
-version = "1.2.3"
+version = "1.2.4"
 
 [deps]
 BitIntegers = "c3b6d118-76ef-56ca-8cc7-ebb389d030a1"

diff --git a/src/arraytypes/fixedsizelist.jl b/src/arraytypes/fixedsizelist.jl
@@ -38,7 +38,7 @@ Base.size(l::FixedSizeList) = (l.ℓ,)
         return missing
     else
         off = (i - 1) * N
-        if X === T && isbitstype(Y)
+        if X === T && isbitstype(Y) && l.data isa Vector{UInt8}
             tup = _unsafe_load_tuple(NTuple{N,Y}, l.data, off + 1)
         else
             tup = ntuple(j->l.data[off + j], N)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -236,12 +236,19 @@ av = Arrow.toarrowvector(CategoricalArray(["a", "bb", "ccc"]))
 @test eltype(av) == String
 
 # 121
-
 a = PooledArray(repeat(string.('S', 1:130), inner=5), compress=true)
 @test eltype(a.refs) == UInt8
 av = Arrow.toarrowvector(a)
 @test eltype(av.indices) == Int16
 
+# 123
+t = (x = collect(zip(rand(10), rand(10))),)
+io = IOBuffer()
+Arrow.write(io, t)
+seekstart(io)
+t2 = Arrow.Table(io)
+@test t2.x == t.x
+
 end # @testset "misc"
 
 end