-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compatibility of schemas with nested types (#504)
Hi, Here is a minimal example of the issue I've encountered. ```julia struct A x::Int end struct B a::A end v = [B(A(i)) for i =1:3] io = IOBuffer() Arrow.write(io, v; file=false) seekstart(io) Arrow.append(io, v) # throws ``` I don't know if this is really necessary, or if I'm not using this library properly, but this issue makes it difficult to append to arrow files with nested types. Since I've only added more cases where the call to `append` can succeed, I do not think that this creates retro-compatibility issues. Thanks for the review! --------- Co-authored-by: Ben Baumgold <[email protected]>
- Loading branch information
Showing
3 changed files
with
44 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
name = "Arrow" | ||
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45" | ||
authors = ["quinnj <[email protected]>"] | ||
version = "2.7.1" | ||
version = "2.7.2" | ||
|
||
[deps] | ||
ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/106211
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baumgold Could you use this process https://github.com/apache/arrow-julia/blob/main/dev/release/README.md when we release a new version of this repository?
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou - my mistake, apologies. It’s been too long and the process slipped my mind. I will in the future.
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
We already registered this version to the General registry but I'll start a vote for this version to follow the ASF guideline.
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vote thread: https://lists.apache.org/thread/ohxg61sgg4fmpj0j3gzttxtsdrgjn6gr
64fc730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: https://lists.apache.org/thread/l6f34ytsxjfhsk4zhdrs30gghg4tt3p7