Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] NOTICE.txt should be present on the repo #203

Closed
raulcd opened this issue Nov 26, 2024 · 3 comments · Fixed by #257
Closed

[Docs] NOTICE.txt should be present on the repo #203

raulcd opened this issue Nov 26, 2024 · 3 comments · Fixed by #257
Assignees
@singh1203
Labels
Type: enhancement New feature or request

Comments

@raulcd
Copy link
Member

raulcd commented Nov 26, 2024

Describe the enhancement requested

From https://www.apache.org/legal/src-headers.html#notice it seems we should have a NOTICE.txt file present on the repo.

Component(s)

Documentation
@raulcd raulcd added the Type: enhancement New feature or request label Nov 26, 2024
@singh1203
Copy link
Contributor

Hello @raulcd I would love to work on it.
And will come up with solution also FYI I will take reference from other's implementations of NOTICE.txt to get best possible solution.

@raulcd
Copy link
Member Author

raulcd commented Jan 20, 2025

Sure, I think we just require the header, as we do with arrow-java:
https://github.com/apache/arrow-java/blob/main/NOTICE.txt

singh1203 added a commit to singh1203/arrow-go that referenced this issue Jan 21, 2025
@singh1203
GH-apache#203: [Docs] Add NOTICE.txt file
15b68d4 
Signed-off-by: Saurabh Kumar Singh <[email protected]>
@singh1203 singh1203 mentioned this issue Jan 21, 2025
Closed
singh1203 added a commit to singh1203/arrow-go that referenced this issue Jan 21, 2025
@singh1203
GH-apache#203: [Docs] Add NOTICE.txt file
f167862 
Signed-off-by: Saurabh Kumar Singh <[email protected]>
@singh1203 singh1203 mentioned this issue Jan 21, 2025
Merged
raulcd pushed a commit that referenced this issue Jan 21, 2025
@singh1203
chore: Add NOTICE.txt file (#257)
218e674 
Fixes #203 
### What changes are included in this PR?
Added the NOTICE.txt file as per the
[Notice](https://www.apache.org/legal/src-headers.html#notice)

Signed-off-by: Saurabh Kumar Singh <[email protected]>
@singh1203
Copy link
Contributor

Thank you @raulcd for the Guidance here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singh1203 singh1203

Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add NOTICE.txt file singh1203/arrow-go
Docs notice singh1203/arrow-go
2 participants
@raulcd @singh1203