Skip to content

[AMORO-3226] Provider a better table explorer view#4053

Merged
zhoujinsong merged 4 commits intoapache:masterfrom
majin1102:table-explorer
Jan 22, 2026
Merged

[AMORO-3226] Provider a better table explorer view#4053
zhoujinsong merged 4 commits intoapache:masterfrom
majin1102:table-explorer

Conversation

@majin1102
Copy link
Contributor

@majin1102 majin1102 commented Jan 20, 2026

Why are the changes needed?

Close #3226.

Brief change log

The new UI looks like:
image

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Jan 20, 2026
@majin1102 majin1102 changed the title Provider a better table explorer view [AMORO-3226] Provider a better table explorer view Jan 20, 2026
- Replace Chinese-only comments in new table explorer views with English equivalents to avoid non-ASCII comments in the codebase
- Remove unused `hideTablesMenu` helper from tables view while keeping runtime behavior unchanged
- Re-run Maven compile (`mvn -q -DskipTests compile`) to ensure Java modules still compile successfully after the cleanup

Co-Authored-By: Aime <aime@bytedance.com>
Change-Id: I618daa3eb9097ab9e9fe4d68f4581431cbac5bf7
@zhoujinsong
Copy link
Contributor

Clipboard_Screenshot_1768965163

I found that when I don't select any table, the table details page still displays, but encounters errors. Should we provide an empty page here to avoid such errors?

@majin1102
Copy link
Contributor Author

majin1102 commented Jan 21, 2026

Two optimization suggested from @zhoujinsong and @xxubai

  1. We can now click anywhere on a row to expand or collapse a catalog/database
  2. If you don’t select a table, the content on the right stays empty.

Check that out when you have time!

@zhoujinsong
Copy link
Contributor

Thanks a lot for the improvement.

I found that when I select an empty database now, the table details page still displays, but it encounters errors.

Clipboard_Screenshot_1769000134

@majin1102
Copy link
Contributor Author

I found that when I select an empty database now, the table details page still displays, but it encounters errors.

Check it now

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in my local environment.

Thanks a lot for the improvement!

@zhoujinsong zhoujinsong merged commit 2bda3ab into apache:master Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-dashboard Ams dashboard module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants