Skip to content

[AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report #4045

Open
czy006 wants to merge 2 commits intoapache:masterfrom
czy006:issues/amoro-4034
Open

[AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report #4045
czy006 wants to merge 2 commits intoapache:masterfrom
czy006:issues/amoro-4034

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Jan 16, 2026

[Improvement]: MaintainerMetrics Unified interface and Report (#4034)

Why are the changes needed?

Close #4034 .

Brief change log

  • MaintainerMetrics interface is abstracted to support a multi-lake architecture
  • Maintainer Metrics add other maintainer metrics interface: such as expireSnapshots/expireData/cleanDanglingDeleteFiles/autoCreateTags
  • MaintainerMetrics OrphanDataFiles method Change to a more general implementation

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 25.59242% with 157 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.49%. Comparing base (869860e) to head (1853680).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...ats/iceberg/maintainer/IcebergTableMaintainer.java 10.77% 146 Missing and 3 partials ⚠️
...org/apache/amoro/maintainer/MaintainerMetrics.java 25.00% 6 Missing ⚠️
...n/src/main/java/org/apache/amoro/TableRuntime.java 0.00% 1 Missing ⚠️
...ache/amoro/maintainer/MaintainerOperationType.java 90.90% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (869860e) and HEAD (1853680). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (869860e) HEAD (1853680)
core 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4045      +/-   ##
============================================
- Coverage     28.63%   22.49%   -6.15%     
+ Complexity     3942     2571    -1371     
============================================
  Files           654      460     -194     
  Lines         52293    42285   -10008     
  Branches       6621     5933     -688     
============================================
- Hits          14973     9511    -5462     
+ Misses        36230    31955    -4275     
+ Partials       1090      819     -271     
Flag Coverage Δ
core ?
trino 22.49% <25.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@czy006 czy006 changed the title Draft: [AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report [AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report Jan 29, 2026
@czy006 czy006 requested a review from baiyangtx January 29, 2026 02:06
@czy006 czy006 force-pushed the issues/amoro-4034 branch 2 times, most recently from a4468f3 to 0cfa9a4 Compare January 29, 2026 08:56
Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Left some comments

@czy006 czy006 force-pushed the issues/amoro-4034 branch 3 times, most recently from 8acb4c4 to d69deba Compare February 5, 2026 08:00
@czy006 czy006 force-pushed the issues/amoro-4034 branch from d69deba to c63f243 Compare February 5, 2026 08:50
@czy006 czy006 requested a review from majin1102 February 5, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: MaintainerMetrics Unified interface and Report

3 participants