Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass extra parameters to Hive Client Wrapper connection #45071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ability to pass extra parameters to Hive Client Wrapper connection #45071

wants to merge 2 commits into from
+114 −4

Conversation

tomwit-nx
Copy link

@tomwit-nx tomwit-nx commented Dec 19, 2024 •
edited by eladkal
Loading

Closes: #45049

Add extra fields to Hive Client Wrapper connection so it is possible to pass extra parameters which are used to construct JDBC connection string. The extra fields are SSL Trust Store, SSL Trust Store password and Transport mode.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Dec 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@tomwit-nx tomwit-nx force-pushed the apache-hive-extra-beeline-params branch 2 times, most recently from 201e71a to d01edef Compare December 21, 2024 16:38
@tomwit-nx tomwit-nx force-pushed the apache-hive-extra-beeline-params branch from 7a85968 to 1e4bf2d Compare December 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk Awaiting requested review from potiuk

@ashb ashb Awaiting requested review from ashb

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:providers kind:documentation provider:apache-hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for extra JDBC parameters for Hive Client Wrapper in apache-hive provider
1 participant
@tomwit-nx