Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid extra fields in execution API request and response models #44978

Open
amoghrajesh opened this issue Dec 17, 2024 · 2 comments · May be fixed by #44986
Open

Forbid extra fields in execution API request and response models #44978

amoghrajesh opened this issue Dec 17, 2024 · 2 comments · May be fixed by #44986
Assignees
Labels
area:API Airflow's REST/HTTP API area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK good first issue

Comments

@amoghrajesh
Copy link
Contributor

amoghrajesh commented Dec 17, 2024

Body

Reference: https://github.com/apache/airflow/pull/44562/files#r1869482261

In lieueu of the above comment, we should update all the request and response models for execution API to forbid any extra fields. Although it makes more sense to do so for any of the PUT/POST APIs. Check under airflow/api_fastapi/execution_api/datamodels/*.py to find all the models. These models will be in sync with what is present in task_sdk/src/airflow/sdk/api/datamodels/_generated.py. Idea is to update airflow/api_fastapi/execution_api/datamodels/*.py first and make relevant changes to task_sdk/src/airflow/sdk/api/datamodels/_generated.py after.

@amoghrajesh amoghrajesh added good first issue area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK labels Dec 17, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Dec 17, 2024
@jx2lee
Copy link
Contributor

jx2lee commented Dec 17, 2024

Can I take over this ? If you assign it to me, I'll take a quick look at it.
(Do I create and link a PR first?)

@amoghrajesh
Copy link
Contributor Author

Go for it. I will assign to you, you can start working on it

@jx2lee jx2lee linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants