Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDFLIB: add getFileContent in rdfLib package. #33

Open
zheyxu opened this issue May 13, 2024 · 4 comments
Open

RDFLIB: add getFileContent in rdfLib package. #33

zheyxu opened this issue May 13, 2024 · 4 comments
Assignees

Comments

@zheyxu
Copy link
Collaborator

zheyxu commented May 13, 2024

No description provided.

@cdawei
Copy link
Collaborator

cdawei commented May 13, 2024

It seems we also have another function (similar to getFileContent) that parses a TTL string and returns a map: Map<String, dynamic> parseTTL(String ttlContent)

@gjwgit
Copy link
Contributor

gjwgit commented May 13, 2024

... and more logically named too!

@zheyxu zheyxu linked a pull request Jul 9, 2024 that will close this issue
@gjwgit
Copy link
Contributor

gjwgit commented Jul 17, 2024

The aim here is to remove duplicated code from the package, clean it up, use sensible function names.

Is this now in a PR? once merged can be closed.

@cdawei
Copy link
Collaborator

cdawei commented Jul 17, 2024

I personally think this is not a good fit for rdflib which represents a turtle document using a graph that is more versatile than using a map (as done by getFileContent()).

If representing triples using a map is a common requirement in solid apps we develop, then perhaps adding and exporting a utility function in solidpod to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants