Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer [id="123"] vs. #\31 23 #67

Open
eoghanmurray opened this issue Apr 27, 2023 · 1 comment
Open

Prefer [id="123"] vs. #\31 23 #67

eoghanmurray opened this issue Apr 27, 2023 · 1 comment

Comments

@eoghanmurray
Copy link

It took me quite a while to work out what was going on with ids when they started with a numeral:

#\\34 69bb17329ad2642a43d .jss138

IMO, the above is not great for display purposes.

Could we switch to the following format instead?

[id="469bb17329ad2642a43d"] .jss138"
eoghanmurray added a commit to eoghanmurray/finder that referenced this issue Apr 27, 2023
@eoghanmurray
Prefer attribute style selector when an id starts with a digit - anto…
9688401 
…nmedv#67
@eoghanmurray eoghanmurray mentioned this issue Apr 27, 2023
Open
@antonmedv
Copy link
Owner

I see. Let's just drop #\3 and use [id=]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonmedv @eoghanmurray