Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: prepend contextual text instead of appending it to chunks in guide.ipynb #95

Open
FlorianPydde opened this issue Sep 22, 2024 · 0 comments

Comments

@FlorianPydde
Copy link

In your blob post, you mention that your prepend the context to the actual chunk but in the guide notebook it's the opposite. It probably doesn't affect performances but for consistency I thought I would raise it.

The line in question is this one (guide):
Current:

'text_to_embed': f"{chunk['content']}\n\n{contextualized_text}"

Corrected:

'text_to_embed': f"{contextualized_text}\n\n{chunk['content']}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant