Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The strings read from package.json should be Markdown escaped #13

Closed
5 of 7 tasks
rioj7 opened this issue Nov 14, 2024 · 0 comments · Fixed by #14
Closed
5 of 7 tasks

The strings read from package.json should be Markdown escaped #13

rioj7 opened this issue Nov 14, 2024 · 0 comments · Fixed by #14
Labels
bug Something isn't working pr welcome

Comments

@rioj7
Copy link
Contributor

rioj7 commented Nov 14, 2024

Describe the bug

The package.json from vuejs/language-tools#5004 generates a broken Marketplace page.

Certain content in package.json strings can break the Markdown HTML generation

The string

Split <script>, <template>, <style> Editors

Will be interpreted as having HTML literal tags.

The string

Auto add space between double curly brackets: {{|}} -> {{ | }}

The | will be interpreted as table separators

At least the following characters should be escaped

Character Markdown Escape
< &lt;
> &gt;
| &vert;

Reproduction

NA

System Info

NA

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@antfu antfu added bug Something isn't working pr welcome labels Nov 15, 2024
rioj7 added a commit to rioj7/vscode-ext-gen that referenced this issue Nov 15, 2024
@antfu antfu closed this as completed in #14 Dec 17, 2024
@antfu antfu closed this as completed in 6303655 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants