Merge PR #111

Author: zhengchun

query.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"hash/fnv"
 	"reflect"
+	"strconv"
 )
 
 // The return type of the XPath expression.
@@ -1364,34 +1365,40 @@ func getHashCode(n NodeNavigator) uint64 {
 	var sb bytes.Buffer
 	switch n.NodeType() {
 	case AttributeNode, TextNode, CommentNode:
-		sb.WriteString(fmt.Sprintf("%s=%s", n.LocalName(), n.Value()))
+		sb.WriteString(n.LocalName())
+		sb.WriteByte('=')
+		sb.WriteString(n.Value())
 		// https://github.com/antchfx/htmlquery/issues/25
 		d := 1
 		for n.MoveToPrevious() {
 			d++
 		}
-		sb.WriteString(fmt.Sprintf("-%d", d))
+		sb.WriteByte('-')
+		sb.WriteString(strconv.Itoa(d))
 		for n.MoveToParent() {
 			d = 1
 			for n.MoveToPrevious() {
 				d++
 			}
-			sb.WriteString(fmt.Sprintf("-%d", d))
+			sb.WriteByte('-')
+			sb.WriteString(strconv.Itoa(d))
 		}
 	case ElementNode:
 		sb.WriteString(n.Prefix() + n.LocalName())
 		d := 1
 		for n.MoveToPrevious() {
 			d++
 		}
-		sb.WriteString(fmt.Sprintf("-%d", d))
+		sb.WriteByte('-')
+		sb.WriteString(strconv.Itoa(d))
 
 		for n.MoveToParent() {
 			d = 1
 			for n.MoveToPrevious() {
 				d++
 			}
-			sb.WriteString(fmt.Sprintf("-%d", d))
+			sb.WriteByte('-')
+			sb.WriteString(strconv.Itoa(d))
 		}
 	}
 	h := fnv.New64a()

xpath_function_test.go

@@ -262,3 +262,36 @@ func Benchmark_ConcatFunc(b *testing.B) {
 		_ = concatFunc(testQuery("a"), testQuery("b"))(nil, nil)
 	}
 }
+
+func Benchmark_GetHashCode(b *testing.B) {
+	// Create a more complex test node that will actually go through the full getHashCode paths
+	doc := createNavigator(book_example)
+	doc.MoveToRoot()
+	doc.MoveToChild() // Move to the first element
+	doc.MoveToChild() // Deeper
+	// Find a node with attributes
+	var node NodeNavigator
+	for {
+		if doc.NodeType() == AttributeNode || doc.NodeType() == TextNode || doc.NodeType() == CommentNode {
+			node = doc.Copy()
+			break
+		}
+		if !doc.MoveToNext() {
+			if !doc.MoveToChild() {
+				// If we can't find a suitable node, default to using the first element
+				doc.MoveToRoot()
+				doc.MoveToChild()
+				node = doc.Copy()
+				break
+			}
+		}
+	}
+
+	b.Run("getHashCode", func(b *testing.B) {
+		b.ReportAllocs()
+		for i := 0; i < b.N; i++ {
+			n := node.Copy()
+			_ = getHashCode(n)
+		}
+	})
+}