fix(stocks.go): remove unnecessary stock not found error responses to simplify error handling

fix(year_validator.go): change error status from BadRequest to NotFound for missing year parameter to better reflect the error context

Author: anqorithm

internal/handlers/stocks.go

@@ -29,10 +29,6 @@ func (h *Handler) GetStocksByYearHandler(c *fiber.Ctx) error {
 		return SendError(c, fiber.StatusInternalServerError, models.ErrCodeDatabaseError,
 			"Failed to parse stocks", nil)
 	}
-	if len(stocks)==0 {
-		return c.Status(404).JSON(fiber.Map{"error": "Stock Not Found We could not find any stock matching your criteria. Please verify your search parameters and try again. "});
-	}
-
 	result := make([]models.Stock, 0, len(stocks))
 	for _, doc := range stocks {
 		stock := models.Stock{
@@ -78,9 +74,6 @@ func (h *Handler) SearchStocksHandler(c *fiber.Ctx) error {
 	if err := cursor.All(c.Context(), &stocks); err != nil {
 		return c.Status(500).JSON(fiber.Map{"error": "Failed to parse stocks"})
 	}
-	if len(stocks)==0 {
-		return c.Status(404).JSON(fiber.Map{"error": "Stock Not Found We could not find any stock matching your criteria. Please verify your search parameters and try again. "});
-	}
 	result := make([]models.Stock, 0, len(stocks))
 	for _, doc := range stocks {
 		stock := models.Stock{

internal/middleware/year_validator.go

@@ -18,12 +18,12 @@ func ValidateYear() fiber.Handler {
 	return func(c *fiber.Ctx) error {
 		year := c.Params("year")
 		if year == "" {
-			return handlers.SendError(c, fiber.StatusBadRequest, 
+			return handlers.SendError(c, fiber.StatusNotFound,
 				models.ErrCodeValidationFailed,
 				"Year parameter is required",
 				fiber.Map{
 					"available_years": availableYears,
-					"example": fmt.Sprintf("/api/v1/stocks/year/%s", availableYears[len(availableYears)-1]),
+					"example":         fmt.Sprintf("/api/v1/stocks/year/%s", availableYears[len(availableYears)-1]),
 				})
 		}
 
@@ -36,14 +36,14 @@ func ValidateYear() fiber.Handler {
 		}
 
 		if !valid {
-			return handlers.SendError(c, fiber.StatusBadRequest, 
+			return handlers.SendError(c, fiber.StatusNotFound,
 				models.ErrCodeValidationFailed,
-				fmt.Sprintf("The year '%s' is not supported", year),
+				fmt.Sprintf("Year '%s' not found", year),
 				fiber.Map{
-					"provided_year":    year,
+					"provided_year":   year,
 					"available_years": availableYears,
-					"latest_year":      availableYears[len(availableYears)-1],
-					"suggestion":       fmt.Sprintf("Try using the latest available year: %s", availableYears[len(availableYears)-1]),
+					"latest_year":     availableYears[len(availableYears)-1],
+					"suggestion":      fmt.Sprintf("Try using the latest available year: %s", availableYears[len(availableYears)-1]),
 				})
 		}