Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate logfire integration at an httpx and sqlalchemy level #37

Open
devraj opened this issue Apr 30, 2024 · 0 comments
Open

Investigate logfire integration at an httpx and sqlalchemy level #37

devraj opened this issue Apr 30, 2024 · 0 comments
Assignees
Milestone

Comments

@devraj
Copy link
Member

devraj commented Apr 30, 2024

Is your feature request related to a problem? Please describe.
@samuelcolvin and team @pydantic have released logfire which is a log observability tool built on top of pydantic.

It supports usage with httpx and sqlalchemy, this ticket is to request a review of the functionality it provides and see if there's value in integrating it into the library.

Describe the solution you'd like
The idea came to me from use cases around using this library for commercial products and that we could benefit from get some observability as the applications scale up.

Key points to consider:

  • Authentication against the logfile service
  • Make it an opt-in function because of performance and the fact that you need to be part of the service
  • Make it an optional endpoint so the user does not have to vendor logfile in by default

Describe alternatives you've considered
NA

Additional context
Study the logfile implementation to learn about async use of logging messages with the service without affecting the performance of the framework.

@devraj devraj self-assigned this Apr 30, 2024
@devraj devraj added this to the 1.1.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant