Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the use of keyring to store API Keys #32

Open
devraj opened this issue Apr 14, 2024 · 0 comments
Open

Investigate the use of keyring to store API Keys #32

devraj opened this issue Apr 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@devraj
Copy link
Member

devraj commented Apr 14, 2024

Is your feature request related to a problem? Please describe.
Ideally the gallagher token is provided by other mechanism (e.g environment variable) that is set by the user. Note that the API Key is generated by the Command Centre which is then passed as headers to the command centre (or via the proxy)

Describe the solution you'd like
Consider the use of a package like keyring to store credentials from the Gallagher command centre.

More importantly we should debate if this is the right approach (the consideration here is that we have tui and cli applications which are public facing as opposed to developer centred).

Describe alternatives you've considered
NA

Additional context
Given the way keychains behave in Windows, we might have to provide substantial documentation for users to get this working properly.

@devraj devraj added the enhancement New feature or request label Apr 14, 2024
@devraj devraj self-assigned this Apr 14, 2024
@devraj devraj added this to the beta-1 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant