Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORB uses audio-or-video-type-pattern-matching-algorithm in an indeterministic way. #40

Open
farre opened this issue Apr 14, 2023 · 1 comment

Comments

@farre
Copy link

farre commented Apr 14, 2023

When sniffing in an audio or video context to achieve a deterministic sniff in a majority of cases, the number of bytes sniffed needs to be more than or equal to 1445. ORB asks for 1024. We should at least change this to be reading-the-resource-header instead.

A caveat here is that this might not be enough. In some cases we need up to 8k for aac in adts (I'm citing stuff I've learned from @padenot here), but we should at least do 1445, which we would do if we change to using reading-the-resource-header.

@farre
Copy link
Author

farre commented Apr 14, 2023

There also seems to be instances of sites streaming media, where streaming doesn't start at the beginning, which complicates things.

C.f. bugzilla 1827684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant