Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI/tests #44

Open
Enigmage opened this issue Dec 3, 2020 · 5 comments
Open

Setup CI/tests #44

Enigmage opened this issue Dec 3, 2020 · 5 comments

Comments

@Enigmage
Copy link
Contributor

Enigmage commented Dec 3, 2020

Opening this on the request of @ankingcodes . It would be helpful to have an automated CI system that can test all PRs for proper coding style (proper indentation and other python standards) and merge/reject them based on the results.

@lucifer0987
Copy link
Contributor

@Enigmage Are you working on this one? I am asking since you have created this issue and haven't specified if you are working or not. If you are not working, i would like to work on it.

@Enigmage
Copy link
Contributor Author

Enigmage commented Dec 3, 2020

@lucifer0987 Yeah sure go ahead. I'm not expecting this one to be only assigned to myself. Anyone can work on adding tests as mentioned in #45.

@ankushbhardwxj
Copy link
Owner

ankushbhardwxj commented Dec 4, 2020

@lucifer0987 @Enigmage - The tests are independent to the CI, the CI will just run all the tests on that branch once a PR is made.

@paramsiddharth
Copy link
Contributor

The issue has been free for a couple of weeks now. May I work on the CI and tests?

@ankushbhardwxj
Copy link
Owner

@paramsiddharth - before setting up the CI, please make a PR with the tests only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants