Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong window closes on command-w #3659

Open
dae opened this issue Dec 23, 2024 · 0 comments · May be fixed by #3680
Open

Wrong window closes on command-w #3659

dae opened this issue Dec 23, 2024 · 0 comments · May be fixed by #3680
Milestone

Comments

@dae
Copy link
Member

dae commented Dec 23, 2024

The wrong window sometimes closes when using the close window keyboard shortcut in Anki for Mac Version ⁨24.11 (87ccd24)⁩.
Repro steps:

Open the Anki application.
In the main (User 1) window, click Add (to open the Add window) and then click Browse (to open the Browse window).
Click the title bar of the Add window, to focus it.
Press command-w.

Expected: the Add window should close, since it’s focused.
Actual: the Browse window closes.

Originally reported on https://forums.ankiweb.net/t/wrong-window-closes-on-command-w/53194

This happens because the Browse screen is a main window and has its own menubar, complete with Close action. The add window is not, so the browse menubar is retained. We could fix this by making close act on the currently-active window, or removing it from the menubar.

@dae dae added this to the 25.01 milestone Dec 23, 2024
@tampueroc tampueroc linked a pull request Dec 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant