Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

pros & cons scene is not shown #389

Open
1 of 3 tasks
anubhavpulkit opened this issue Mar 18, 2020 · 9 comments
Open
1 of 3 tasks

pros & cons scene is not shown #389

anubhavpulkit opened this issue Mar 18, 2020 · 9 comments

Comments

@anubhavpulkit
Copy link
Contributor

Description

As a user I didn't see any Pro and Cons scene after Minesweeper game,
I need to do changes in minesweeperGameScene.swift,
so that pro and cons UI is visible after Minesweeper mini-game.

Acceptance Criteria

Update [Required]

  • [changes in minesweeperGameScene.swift]

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

[2] hours

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie please review this issue

@sunjunkie
Copy link
Contributor

What pros and cons do you mean?

@anubhavpulkit
Copy link
Contributor Author

anubhavpulkit commented Mar 20, 2020

@sunjunkie In the documentation of 2017 GSoC, it is mention that No matter the game is successful or not, a pros & cons scene is shown when the continue button is clicked. that scene is not visible.

@sunjunkie
Copy link
Contributor

That is old documentation. We should use the Story Designer for pros and cons. So you must create a story with Story Designer with pros and cons (use placeholder text only).

@anubhavpulkit
Copy link
Contributor Author

ok

@anubhavpulkit
Copy link
Contributor Author

I'm Sorry @sunjunkie I'm a little busy in the last days because I'm travelling from College Hostel to my House because of Corona Virus.

@anubhavpulkit
Copy link
Contributor Author

That is old documentation. We should use the Story Designer for pros and cons. So you must create a story with Story Designer with pros and cons (use placeholder text only).

@sunjunkie But I saw pro and cons is available in the codebase.

@sunjunkie
Copy link
Contributor

In 2018 we moved to the Story Designer as a way to provide information to the user rather than a plain screen. So we do want to show pros and cons but in a more appealing way.

@anubhavpulkit
Copy link
Contributor Author

ok @sunjunkie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants