Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Last page bug due to Pagination #107

Open
techno-disaster opened this issue Jun 22, 2020 · 11 comments
Open

Last page bug due to Pagination #107

techno-disaster opened this issue Jun 22, 2020 · 11 comments
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Bug Bug or Bug fixes.

Comments

@techno-disaster
Copy link
Contributor

techno-disaster commented Jun 22, 2020

Describe the bug

Right now if the last page does not have all 20 members (the number of people we request per page). The members get repeated. This is probably due to a small bug in hasReachedMax, to fill the 20 limit.

PS: The data is getting called for all the pages (including the last one) as expected, you can see it in the logs when you scroll to the end. Only the members aren't shown on the app.

To Reproduce
Steps to reproduce the behavior:
Go to members page and scroll to the end.

Screenshots

Screenshot_20200622-084911

@techno-disaster techno-disaster added Type: Bug Bug or Bug fixes. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Jun 22, 2020
@Anirudhk07
Copy link

Can I take this ?

@techno-disaster
Copy link
Contributor Author

Hey @Anirudhk07 sure. assigning it to you

@techno-disaster techno-disaster removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 1, 2020
@techno-disaster
Copy link
Contributor Author

@Anirudhk07 Any update on the issue?

@Akanksha1212 Akanksha1212 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 8, 2020
@Akanksha1212
Copy link
Contributor

Making this issue available for others as there's no response from @Anirudhk07.

@techno-disaster
Copy link
Contributor Author

@bharat-1809 can you take this up?

@bharat-1809
Copy link
Contributor

@techno-disaster Sure, thanks :)

@techno-disaster techno-disaster removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 9, 2020
@techno-disaster
Copy link
Contributor Author

Hey @bharat-1809 any updates?

@bharat-1809
Copy link
Contributor

@techno-disaster I am still working on it. Sorry for the delay.

@techno-disaster
Copy link
Contributor Author

no problem, we just need a update every 3 days :) feel free to ask of you are stuck somewhere.

@bharat-1809
Copy link
Contributor

@techno-disaster I think the issue is already solved. The list didn't get repeated. Please have a look.
20200713_211408

@techno-disaster
Copy link
Contributor Author

Yes, i looked into this and found out an issue on the backend, lets keep this on hold for now. Will raise an issue on the backend repo

@techno-disaster techno-disaster added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

4 participants