Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests [ server tests ] for the project #21

Open
anikethsaha opened this issue May 6, 2019 · 11 comments
Open

Adding tests [ server tests ] for the project #21

anikethsaha opened this issue May 6, 2019 · 11 comments
Labels

Comments

@anikethsaha
Copy link
Owner

anikethsaha commented May 6, 2019

The test library I am planning to use is jest.
category of tests :

  • API tests
  • Snapshot tests

For now just two, please add more if works fine

Example of a test in chai

describe('/GET /', () => {
    it('it should GET all the books', (done) => {
      chai.request(server)
          .get('/')
          .end((err, res) => {
                res.should.have.status(200);
            done();
          });
    });
});

Thanks

@anikethsaha anikethsaha added the help wanted Extra attention is needed label May 6, 2019
@anikethsaha anikethsaha added the good first issue Good for newcomers label May 14, 2019
@anikethsaha anikethsaha mentioned this issue Jun 29, 2019
8 tasks
@anikethsaha anikethsaha added the v1 label Jun 29, 2019
@anikethsaha anikethsaha added this to the v1 milestone Jun 29, 2019
@anmol5varma
Copy link

I can provide some help.

@anikethsaha
Copy link
Owner Author

@anmol5varma that's great.
Ping me if you need any help from my side.

@anmol5varma
Copy link

@anikethsaha Do you have some folder structure in mind?

@anikethsaha
Copy link
Owner Author

folder structure for tests?

if so, then the current seems fine like a separate test folder at the root!

and if the about the project, then I guess I may have 2nd thoughts over the present one. Cause I have made a separate folder for the component which can be shared by both server and the client mainly had a better SSR solution in my mind. So would appreciate any suggestion over this.

@anmol5varma
Copy link

Generally while working we have component test inside them only. Hence I would advise if we have tests on the concerned files at the same level. I have written snapshot tests for the client folder with the same logic.

@anikethsaha
Copy link
Owner Author

Okay it's fine either way. You can go ahead with your tests.
If possible try to make it at the root but tests are more important irrespective of where they are so gi ahead, add your tests.
Looking forward for your PR

@anikethsaha anikethsaha changed the title Adding tests for the project Adding tests [ server tests ] for the project Oct 5, 2019
@manas2297
Copy link

is it still open to work?

@anikethsaha
Copy link
Owner Author

Yeah.... It's open....
Feel free to reach out to me if you need any help

@anikethsaha
Copy link
Owner Author

@manas2297 are you planning to add tests for the server?

@anikethsaha anikethsaha removed this from the v1 milestone Oct 17, 2019
@AlisherU
Copy link

Hi @anikethsaha, do you still need help with this?

@sheethalpatila
Copy link

Hi @anikethsaha and team,

I’m [Sheethal Patil A], a [MERN fullstack developer] with experience in the MERN stack (MongoDB, Express, React, Node.js). I’ve been looking for opportunities to contribute to open-source projects, and I’m really impressed by the work you’re doing with this project.

I’d love to help with this issue [ Link ], as it seems to align well with my skills in [React and Node.js]. I’ve taken a look at the code and I’m ready to dive in. Is there anything specific you’d like me to focus on, or any additional context I should be aware of before getting started?

If there are other areas where you need help, please let me know! I’m eager to contribute and learn more.

Looking forward to your guidance!

Best regards,
[Sheethal Patil A]
[Profile]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants