fix(aria/spinbutton): address review feedback

- Remove unnecessary setDefaultState effect and related code
- Clarify setDefaultState JSDoc is intentionally empty
- Use native ARIA binding syntax in increment and input
- Update API golden

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: OmerGronich

goldens/aria/spinbutton/index.api.md

@@ -20,7 +20,6 @@ export class SpinButton {
     readonly inputId: _angular_core.InputSignal<string>;
     readonly max: _angular_core.InputSignal<number | undefined>;
     readonly min: _angular_core.InputSignal<number | undefined>;
-    _onFocus(): void;
     readonly pageStep: _angular_core.InputSignal<number | undefined>;
     readonly _pattern: SpinButtonPattern;
     readonly readonly: _angular_core.InputSignalWithTransform<boolean, unknown>;
@@ -36,8 +35,8 @@ export class SpinButton {
 
 // @public
 export class SpinButtonDecrement {
-    readonly _isDisabled: _angular_core.Signal<boolean>;
-    _onClick(): void;
+    protected readonly _isDisabled: _angular_core.Signal<boolean>;
+    protected _onClick(): void;
     readonly spinButton: SpinButton;
     // (undocumented)
     static ɵdir: _angular_core.ɵɵDirectiveDeclaration<SpinButtonDecrement, "[ngSpinButtonDecrement]", ["ngSpinButtonDecrement"], {}, {}, never, never, true, never>;
@@ -47,8 +46,8 @@ export class SpinButtonDecrement {
 
 // @public
 export class SpinButtonIncrement {
-    readonly _isDisabled: _angular_core.Signal<boolean>;
-    _onClick(): void;
+    protected readonly _isDisabled: _angular_core.Signal<boolean>;
+    protected _onClick(): void;
     readonly spinButton: SpinButton;
     // (undocumented)
     static ɵdir: _angular_core.ɵɵDirectiveDeclaration<SpinButtonIncrement, "[ngSpinButtonIncrement]", ["ngSpinButtonIncrement"], {}, {}, never, never, true, never>;

src/aria/private/spinbutton/spinbutton.ts

@@ -106,7 +106,7 @@ export class SpinButtonPattern {
     return [];
   }
 
-  /** Sets the spinbutton to its default initial state. */
+  /** Noop. Spinbuttons don't manage items requiring default state initialization. */
   setDefaultState(): void {}
 
   /** Handles keydown events for the spinbutton. */

src/aria/spinbutton/spinbutton-increment.ts

@@ -26,8 +26,8 @@ import {SPINBUTTON} from './spinbutton-tokens';
   selector: '[ngSpinButtonIncrement]',
   exportAs: 'ngSpinButtonIncrement',
   host: {
-    '[attr.aria-controls]': 'spinButton.inputId()',
-    '[attr.aria-disabled]': '_isDisabled() || null',
+    '[aria-controls]': 'spinButton.inputId()',
+    '[aria-disabled]': '_isDisabled() || null',
     '[attr.tabindex]': '-1',
     '(click)': '_onClick()',
   },

src/aria/spinbutton/spinbutton-input.ts

@@ -29,15 +29,14 @@ import {SPINBUTTON, SPINBUTTON_INPUT} from './spinbutton-tokens';
     'role': 'spinbutton',
     '[attr.id]': 'spinButton.inputId()',
     '[tabindex]': 'spinButton._pattern.tabIndex()',
-    '[attr.aria-valuenow]': 'spinButton._pattern.ariaValueNow()',
-    '[attr.aria-valuemin]': 'spinButton.min()',
-    '[attr.aria-valuemax]': 'spinButton.max()',
-    '[attr.aria-valuetext]': 'spinButton.valueText() || null',
-    '[attr.aria-disabled]': 'spinButton.disabled() || null',
-    '[attr.aria-readonly]': 'spinButton.readonly() || null',
-    '[attr.aria-invalid]': 'spinButton._pattern.invalid() || null',
+    '[aria-valuenow]': 'spinButton._pattern.ariaValueNow()',
+    '[aria-valuemin]': 'spinButton.min()',
+    '[aria-valuemax]': 'spinButton.max()',
+    '[aria-valuetext]': 'spinButton.valueText() || null',
+    '[aria-disabled]': 'spinButton.disabled() || null',
+    '[aria-readonly]': 'spinButton.readonly() || null',
+    '[aria-invalid]': 'spinButton._pattern.invalid() || null',
     '(keydown)': '_onKeydown($event)',
-    '(focusin)': 'spinButton._onFocus()',
     '(input)': '_onInput($event)',
     '(change)': '_onChange($event)',
     '[attr.autocomplete]': '_isNativeInput ? "off" : null',

src/aria/spinbutton/spinbutton.ts

@@ -16,7 +16,6 @@ import {
   inject,
   input,
   model,
-  signal,
 } from '@angular/core';
 import {_IdGenerator} from '@angular/cdk/a11y';
 import {SpinButtonPattern} from '../private';
@@ -85,9 +84,6 @@ export class SpinButton {
   /** Signal for the input element reference. */
   private readonly _inputElement = computed(() => this._inputChild()?.element);
 
-  /** Whether the spinbutton has received focus yet. */
-  private _hasFocused = signal(false);
-
   /** The UI pattern instance for this spinbutton. */
   readonly _pattern: SpinButtonPattern = new SpinButtonPattern({
     id: this.inputId,
@@ -104,25 +100,14 @@ export class SpinButton {
   });
 
   constructor() {
-      if (typeof ngDevMode === 'undefined' || ngDevMode) {
-        afterRenderEffect(() => {
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
+      afterRenderEffect(() => {
         const violations = this._pattern.validate();
         for (const violation of violations) {
           console.error(violation);
         }
-    });
-   }
-
-    afterRenderEffect(() => {
-      if (!this._hasFocused()) {
-        this._pattern.setDefaultState();
-      }
-    });
-  }
-
-  /** Called when the input receives focus. */
-  _onFocus(): void {
-    this._hasFocused.set(true);
+      });
+    }
   }
 
   /** Increments the value by the step amount. */