Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript 2.4 support #6827

Closed
xnnkmd opened this issue Jun 28, 2017 · 11 comments · Fixed by #7065
Closed

typescript 2.4 support #6827

xnnkmd opened this issue Jun 28, 2017 · 11 comments · Fixed by #7065
Assignees
@filipesilva
Labels
feature Issue that requests a new feature

Comments

@xnnkmd
Copy link

xnnkmd commented Jun 28, 2017

Bug Report or Feature Request (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

1.1.3

Desired functionality.

Angular-cli should support typescript 2.4 (just released yesterday). Right now angular-cli is locked down to max v2.3
@delasteve
Copy link
Contributor

There's an issue with rxjs right now preventing upgrading the CLI to use TypeScript 2.4. I read that the 6.x versions work, but that is in alpha and could lead to some other issues. ⚠️ Use caution if you intend on upgrading early. ⚠️

Expect the CLI to upgrade its dependencies when things are stable again.

Tracking: ReactiveX/rxjs#2539

@filipesilva filipesilva self-assigned this Jun 29, 2017
@filipesilva filipesilva added feature Issue that requests a new feature type: discussion labels Jun 29, 2017
@moniuch
Copy link

moniuch commented Jun 30, 2017

@delasteve ...by which issue I was bitten today. And I thought about the following one:
Given that even a minor version release of TypeScript can break things, wouldn't it be wise to generate package json without the ^ character specifically for TS?

@tytskyi
Copy link

tytskyi commented Jun 30, 2017

@moniuch cli already generates package with ~. Looks like people are trying to update it manually or had old package.json

see https://github.com/angular/angular-cli/blob/v1.2.0/packages/%40angular/cli/blueprints/ng/files/package.json#L50

@ngfk ngfk mentioned this issue Jul 3, 2017
Closed
@xnnkmd
Copy link
Author

xnnkmd commented Jul 5, 2017

@delasteve @filipesilva RxJS 5.4.2 has now been published with the fix for Typescript 2.4.1

@MarkPieszak
Copy link
Member

MarkPieszak commented Jul 5, 2017 •
edited
Loading

At least from my testing, if you upgrade rxjs to 5.4.2 you should be able to use the CLI with TS 2.4.

Just remember that you're upgrading at your own risk as I don't believe it has been fully tested &/or is supported at the moment.

@filipesilva filipesilva mentioned this issue Jul 5, 2017
Closed
@ghost ghost mentioned this issue Jul 16, 2017
Closed
@smoke
Copy link
Contributor

smoke commented Jul 20, 2017

I think the referenced issue ReactiveX/rxjs#2539 is now fixed, so are there any plans now?

@filipesilva filipesilva mentioned this issue Jul 20, 2017
Merged
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 21, 2017
@filipesilva
feat(@angular/cli): support TypeScript 2.4
4c29033 
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies (`rxjs`, `ts-node`) to the minimum that supports 2.4
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix angular#6827
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 21, 2017
@filipesilva
feat(@angular/cli): support TypeScript 2.4
0372953 
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies to the minimum that supports 2.4 (`rxjs@^5.4.2`, `ts-node@~3.2.0`)
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix angular#6827
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 21, 2017
@filipesilva
feat(@angular/cli): support TypeScript 2.4
420a7a4 
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies to the minimum that supports 2.4 (`rxjs@^5.4.2`, `ts-node@~3.2.0`)
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix angular#6827
Brocco pushed a commit that referenced this issue Jul 21, 2017
@filipesilva @Brocco
feat(@angular/cli): support TypeScript 2.4
7b9fc28 
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies to the minimum that supports 2.4 (`rxjs@^5.4.2`, `ts-node@~3.2.0`)
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix #6827
winksaville added a commit to winksaville/angular-quick-start-my-app that referenced this issue Aug 17, 2017
@winksaville
Update typescript to ~2.4
85c1bb0 
So its now at version 2.4.2 and Angular is apparently now
[compatible](angular/angular-cli#6827).
@OdaiTu
Copy link

OdaiTu commented Oct 7, 2017

how to update my typescript to latest version ?
what is the command using npm ?

asanchezr added a commit to asanchezr/mem-mmti-public that referenced this issue Oct 10, 2017
@asanchezr
MEM-550 Pin the version of NPM dependencies
43ac521 
* Pin typescript to 2.3.4 (was 2.4.0)
Fixes warning on CLI -> angular/angular-cli#6827

* Pin angular to 4.4.4
* Pin angular/cli to 1.2.7
* Remove unused package ngx-bootstrap
* Update yarn.lock file
@asanchezr asanchezr mentioned this issue Oct 10, 2017
Merged
@jbojcic1
Copy link

So is it possible to use typescript >= 2.4 now? I have cli 1.4.6 and it still requires ts < 2.4

@MarkPieszak
Copy link
Member

Try CLI 1.5+

@jbojcic1
Copy link

@MarkPieszak tried it. I still get the same warning.

asanchezr added a commit to asanchezr/eao-public that referenced this issue Oct 13, 2017
@asanchezr
EPIC-1252 Pin the version of NPM dependencies
756c0d5 
* Pin angular to 4.4.4
* Pin angular/cli to 1.2.7
* Pin typescript to 2.3.4 (was 2.4.0) - fixes warning on CLI -> angular/angular-cli#6827
* Update yarn.lock file
@asanchezr asanchezr mentioned this issue Oct 13, 2017
Merged
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@filipesilva @dond2clouds
feat(@angular/cli): support TypeScript 2.4
532e151 
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies to the minimum that supports 2.4 (`rxjs@^5.4.2`, `ts-node@~3.2.0`)
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix angular#6827
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
9 participants
@smoke @delasteve @moniuch @MarkPieszak @tytskyi @filipesilva @jbojcic1 @OdaiTu @xnnkmd