Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validate_panel normalization method to use cohort-wide constants per channel #48

Open
alex-l-kong opened this issue May 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@alex-l-kong
Copy link
Contributor

Describe the bug

Currently, the validate_panel function normalizes each channel separately based on its own 99.9% value. This will accentuate noise for very dim images, which leads to undesirable images.

Expected behavior

The normalization value needs to reflect the cohort as a whole, and not just on an individual level. To address, figure out what the best constants to use for each channel are, and use that to normalize all images across a cohort or sub-cohort.

@alex-l-kong alex-l-kong added the bug Something isn't working label May 7, 2024
@alex-l-kong alex-l-kong self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant