Skip to content

Commit 267f54d

Browse files
authored
Fix weight sorting bug in table (#364)
* Fixed tables not reseting when changing * Fix sorting bug in table * Bump v0.10.4+54
1 parent 0d9a7ae commit 267f54d

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

lib/logic/data/data_fetching.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Future<List<Map<String, dynamic>>> loadNextChunk(
99
DatabaseHelper dbHelper,
1010
) async {
1111
List<Map<String, dynamic>> newData;
12-
bool isNumeric = sortColumn == 'weight';
12+
bool isNumeric = sortColumn == 'Weight';
1313

1414
if (selectedTable == 'exercises') {
1515
newData = await dbHelper.getExercisesChunk(
@@ -18,7 +18,7 @@ Future<List<Map<String, dynamic>>> loadNextChunk(
1818
offset: offset,
1919
limit: limit,
2020
isNumeric: isNumeric,
21-
isDateTime: sortColumn == 'timestamp',
21+
isDateTime: sortColumn == 'Timestamp',
2222
);
2323
} else if (selectedTable == 'fitness') {
2424
newData = await dbHelper.getFitnessDataChunk(
@@ -27,7 +27,7 @@ Future<List<Map<String, dynamic>>> loadNextChunk(
2727
offset: offset,
2828
limit: limit,
2929
isNumeric: isNumeric,
30-
isDateTime: sortColumn == 'timestamp',
30+
isDateTime: sortColumn == 'Timestamp',
3131
);
3232
} else {
3333
newData = [];

lib/widgets/table/table_widget.dart

+8
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ class TableWidgetState extends State<TableWidget> {
5252
loadData(widget.selectedTable);
5353
}
5454

55+
@override
56+
void didUpdateWidget(TableWidget oldWidget) {
57+
super.didUpdateWidget(oldWidget);
58+
if (widget.selectedTable != oldWidget.selectedTable) {
59+
loadData(widget.selectedTable);
60+
}
61+
}
62+
5563
@override
5664
void dispose() {
5765
_verticalScrollController.removeListener(

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
1616
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
1717
# In Windows, build-name is used as the major, minor, and patch parts
1818
# of the product and file versions while build-number is used as the build suffix.
19-
version: 0.10.3+53
19+
version: 0.10.4+54
2020

2121
environment:
2222
sdk: '>=3.4.3 <4.0.0'

0 commit comments

Comments
 (0)