-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am using FP-DSA on mac m1 - macos 12, facing issue "clGetPlatformIDs" while trying to hit FP Models on WSI #2
Comments
That is likely because the pyFAST wheel installed is not built for Silicon. I can add a fix for that after lunch :] pyFAST recently added Silicon-support, so I have not had the time to test this. |
Great! Thanks Looking forward. |
Also can you guide me a bit on how can I add more custom models to it |
I think this can be resolved by running
Right now, adding your own custom pipelines (and models) is not supported. At the time of developing this proof-of-concept plugin, I did not have dedicated funding nor time to do it. If you wish to be able to add custom pipelines and models, it would be better to add a FastPathology-like solution, where the user could add their own FPL files and upload their own models. I do not have time to do this right now, but I may in the near future. If you wish to add support to a single model yourself for testing, you will need to make your own Might be that I have time this weekend to do an iteration. Stay tuned! :] |
is there any FastPathology like solution or maybe alternate to DSA which has support to add custom models |
To the best of my knowledge, no. But I mean, it should be possible to add generic FPL support. Im on the final stretch of my PhD and do not have much time to spare for open-source activites at the moment. Otherwise, I would have made an attempt at implementing a plugin that does exactly that right now. I will have to update the FP plugin soon anyways to test some of my other custom models. Might put more effort into making the plugin more useful for your application. Will let you know! |
Small update, @lomshabhishek! I have been sick the entire week, so I have not had the time to work on this. I still am sick, but I took a look at getting FAST's That means that I can adapt the code to using this solution, which likely will be a lot more generic. I might have time to look at this tomorrow, but I think I will have to rest to fully recover. |
Hello! Regarding the original issue, I believe the very latest release of pyFAST now supports ARM CPUs (M1/M2 chip): I updated the repo to use the latest pyFAST version, so this should (in theory) work: 656e2a5 Could you try to rebuild the docker image from scratch (without cache), to see if that resolves the issue? pyFAST should work on a headless machine, but I am unable to debug this exact problem myself, as I do not own a macbook with ARM CPU. For adding generic FastPathology-like support for adding your own custom pipelines and models, it is likely better to create a separate issue to track that further and/or open a Discussion tab. |
Hmm, I managed to reproduce this issue using the latest pyFAST version on my macbook with regular CPU. So the current solution does not seem to work on macOS overall. |
I think this is due to use building the docker image on top of NVIDIA CUDA Ubuntu 20.04, which results in a different OpenGL version than the one available on macOS: It is not to run on macOS for development, but the end solution will likely be ran on a Linux server, so I do not think I will spend much time adding macOS support to this pipeline. You can make an attempt if you'd like. Added info about this issue to the README: 55a32cd I will rather focus on adding generic FPL support. |
Hi @andreped I faced same issue on linux as well not sure why is that the case
|
Strange that Linux does not work for you. It worked fine for me on my Ubuntu 18.04 desktop, even though the container was running with Ubuntu 20.04. Only thing I changed was the pyFAST version. You can try reverting back to I do not have access to the Linux desktop atm, so I will have to run some tests on my Windows laptop later. Will have to do so after work. |
@andreped While doing multiple iterations I have accumulated a lot of entries under the analyses tab wherein old images are there, what is the best way to remove them? |
@abhisheklomsh I'm not sure what you mean, can you send a snapshot? Are you talking about WSIs you added to your local database through Digital Slide Archive? Next time, for new topics or questions, please make a new Q/A in the Discussions tab (see here). |
Sure slipped from my mind, apologies for the same. |
Can you make a new Discussion now, and we can take it there instead? |
@abhisheklomsh We actually experience something similar to what you are right now, @abhisheklomsh, but sadly I don't personally have a Linux desktop machine to debug it on. Did you manage to get it working on Ubuntu? The reason why it did not work for you on Ubuntu, might be because you were missing |
I still encounter this while trying to run it on ubuntu or when I try to dockerise the installation process.
|
�[0m�[1mWARNING [274890450752] Unable to open X display. Disabling visualization.�[0m
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
Traceback (most recent call last):
File "/usr/local/bin/fastpathology", line 11, in
load_entry_point('fastpathology', 'console_scripts', 'fastpathology')()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 490, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2854, in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2445, in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2451, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/opt/fastpathology/dsa/cli/fastpathology/deploy.py", line 1, in
from .utils import enable_fast_verbosity, download_models, run_pipeline
File "/opt/fastpathology/dsa/cli/fastpathology/utils.py", line 1, in
import fast
File "/usr/local/lib/python3.8/dist-packages/fast/init.py", line 22, in
fast.ImageFileImporter.create('') # Trigger splash, GL context initialization etc.
File "/usr/local/lib/python3.8/dist-packages/fast/fast.py", line 13671, in create
return _fast.ImageFileImporter_create(filename)
RuntimeError: clGetPlatformIDs
The text was updated successfully, but these errors were encountered: