Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required attributes and elements are not enforced #4

Open
trscavo opened this issue Jun 26, 2011 · 2 comments
Open

required attributes and elements are not enforced #4

trscavo opened this issue Jun 26, 2011 · 2 comments
Assignees

Comments

@trscavo
Copy link

trscavo commented Jun 26, 2011

AFAICT, only SP metadata is supported (which is not what this issue is about). If that's true, then the following attributes and elements are REQUIRED in metadata:

/md:EntityDescriptor/@EntityID
/md:EntityDescriptor/md:SPSSODescriptor
/md:EntityDescriptor/md:SPSSODescriptor/@protocolSupportEnumeration
/md:EntityDescriptor/md:SPSSODescriptor/md:AssertionConsumerService

Also, if an /md:EntityDescriptor/md:SPSSODescriptor/md:AttributeConsumingService element is included, then the following two elements are also REQUIRED:

/md:EntityDescriptor/md:SPSSODescriptor/md:AttributeConsumingService/md:ServiceName
/md:EntityDescriptor/md:SPSSODescriptor/md:AttributeConsumingService/md:RequestedAttribute

Experiments indicate that most of the above requirements are NOT enforced, which is a bug IMO. The software should never produce incorrect metadata.

@andreassolberg
Copy link
Owner

I'm expecting a next generation SAMLmetaJS to support IdP metadata. I would like to make the SP version of SAMLmetaJS stable before I start with that. It also depend on if there are interest from real life projects.

Regarding md:AttributeConsumingService this should now be fixed (in mdreader branch, hopefully merged soon - it's a significant update).

  • If attributes are selected without a name, a name 'Unnamed' is added.
  • If name and no attributes are added, the name will survive in the uiinfo element, and therefore the acs element is not added at all.

SAMLmetaJS will allow you to create broken metadata; in example you may move back and forward between the metadata tab and the info tab, and SAMLmetaJS will create temporary metadata for you even if the entityID not yet is added.

I'm working on including a metadata validator in SAMLmetaJS, which will show you a list of 'Issues that needs to be solved in metadata'. These rules for verification will be based upon rulesets that may be configured differnetly from deployment to deployment, as requirements differ. I also plan on making an option for disabling the 'Save' button until all issues with metadata is solved.

@ghost ghost assigned andreassolberg Aug 10, 2011
@andreassolberg
Copy link
Owner

Work on metadata verification is started in the mdverify branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants