Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble coordinate errors from stereoscope #3415

Open
kzantow opened this issue Nov 4, 2024 · 0 comments
Open

Bubble coordinate errors from stereoscope #3415

kzantow opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kzantow
Copy link
Contributor

kzantow commented Nov 4, 2024

Syft surfaces errors encountered with references to the file from which they originate -- this happens at the Syft level, but not lower level like stereoscope, which can have reference to the path(s). we want to generalize this behavior to occur for all errors returned from a file.Resolver, not just those encountered in the binary cataloger. #3410 was a quick fix to an immediate problem that is temporary until the changes described here get implemented.

Specifically, what was discussed:

  • modify stereoscope to include a "path error" of some sort -- one that has a path and an error, for example, when a cycle is returned to include the file which caused it, and update calls to return this error type as appropriate
  • make a file.Resolver decorator which converts stereoscope path errors to unknowns/coordinate errors on each error-returning implementation call
  • update the binary classifier to split coordinate errors and remaining, warn log remaining, and remove this behavior from the ProcessPathError
@kzantow kzantow added the bug Something isn't working label Nov 4, 2024
@kzantow kzantow self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant