-
Notifications
You must be signed in to change notification settings - Fork 575
Can't upgrade from 0.12.6 -> 0.12.7 #1269
Comments
@marc0tjevp That's an odd one; mind trying it again? |
@CraigChilds94 I just tried again, still the same result. |
I received a dancing robot... What's the network tab say? Maybe there's an
issue with how it grabs the zip from GitHub?
…On Thu, Mar 8, 2018 at 9:42 AM, Marco van Poortvliet < ***@***.***> wrote:
@CraigChilds94 <https://github.com/craigchilds94> I just tried again,
still the same result.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1269 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbfK8LkPgAK-ZIyklqiUiYJDMiNHnX5ks5tcHdlgaJpZM4SgOFd>
.
|
@TheBrenny Checked the network tab, there's no request. Clicking the button just adds a # to the url. |
wow, Zepto again. From what @TheBrenny just said, I'd guess the the handler for the button is malformed. From @joshvickerson's stacktrace, it looks like the event is firing and request is sending, but the response is not not what's expected. Could be another push towards that Vanilla rewrite we talked about. All these JS bugs might shake out if we just refactored Zepto out of the picture... |
@evansharp The stacktrace also looks like it's more an issue with what the server is sending back; ie, it's not actually sending a JSON response... This usually happens becuase we (probably I) may have missed a step in setting the return to be JSON instead of HTML. |
@TheBrenny But of course if we replaced Zepto, bugs like that would come out in the wash ;) |
Summary
When promped with an upgrade, the download buttons does not work, clicking it returns
sendAjax is not a function
in the console.Expected Behaviour
The upgrade downloads and is applied.
Actual Behaviour
Context details (if applicable)
The text was updated successfully, but these errors were encountered: