[Feature request]: napi_build_skb support?

[JonKohler]

Preliminary Actions

• I have searched the existing issues and didn't find a duplicate.

Driver Type

Linux kernel driver for Elastic Network Adapter (ENA)

Motivation

Reduce build_skb overheads

Solution

Was doing some spot checking, and noticed that the ENA driver uses build_skb vs napi_build_skb. I see that was reverted here: bad09ae

Was wondering if there was any follow on work to that revert to attempt to reintroduce this?

The revert was light on details on what sort of issues napi_consume_skb introduced that prompted this revert, was wondering if that was kernel version specific? or instance type specific only?

Anyhow, we've seen nice-ness from napi_build_skb in other parts of our environment, would love to see if we could use that in ENA as well?

Contact Details

jon@nutanix.com

[davidarinzon]

Hi @JonKohler

Thanks for reaching out.

Our experiments at the time were with kernel 5.10 and we've observed degradation as mentioned in the revert commit that you've shared.
We have plans of exploring napi_consume_skb and napi_build_skb in the future.

Please stay tuned for updates.