Fix #6 -- Switch to settings dictionary (#8)

Author: amureki

README.md

@@ -30,20 +30,19 @@ MIDDLEWARE = [
 
 ## Configuration
 
-```python
-# Position: bottom-right, bottom-left, top-right, top-left (default: bottom-right)
-DEVBAR_POSITION = "top-left"
-
-# Show HTML overlay (default: DEBUG)
-DEVBAR_SHOW_BAR = True
+All settings are optional. Configure via a `DEVBAR` dict in your Django settings:
 
-# Add DevBar-* response headers (default: False)
-DEVBAR_SHOW_HEADERS = True
+```python
+DEVBAR = {
+    'POSITION': 'bottom-right',  # bottom-right, bottom-left, top-right, top-left
+    'SHOW_BAR': None,            # None (default) = follows DEBUG, or True/False to override
+    'SHOW_HEADERS': False,       # Add X-DevBar-* headers to responses
+}
 ```
 
 ## Response Headers
 
-When `DEVBAR_SHOW_HEADERS = True`, performance metrics are added as HTTP response headers. This is useful for:
+When `DEVBAR = {'SHOW_HEADERS': True}`, performance metrics are added as HTTP response headers. This is useful for:
 
 - **API endpoints** where the HTML overlay can't be displayed
 - **Automated testing** to assert performance metrics (e.g., fail CI if query count exceeds a limit)

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "django-devbar"
-version = "0.1.3"
+version = "0.2.0"
 description = "Lightweight performance devbar for Django"
 readme = "README.md"
 license = "MIT"

src/django_devbar/__init__.py

@@ -1,4 +1,3 @@
 from .middleware import DevBarMiddleware
 
-__version__ = "0.1.3"
 __all__ = ["DevBarMiddleware"]

src/django_devbar/conf.py

@@ -8,14 +8,26 @@
 }
 
 
+def get_config():
+    return {
+        "POSITION": "bottom-right",
+        "SHOW_BAR": None,  # None = use settings.DEBUG
+        "SHOW_HEADERS": False,
+        **getattr(settings, "DEVBAR", {}),
+    }
+
+
 def get_position():
-    key = getattr(settings, "DEVBAR_POSITION", "bottom-right")
+    config = get_config()
+    key = config["POSITION"]
     return POSITIONS.get(key, POSITIONS["bottom-right"])
 
 
 def get_show_bar():
-    return getattr(settings, "DEVBAR_SHOW_BAR", settings.DEBUG)
+    config = get_config()
+    show_bar = config["SHOW_BAR"]
+    return settings.DEBUG if show_bar is None else show_bar
 
 
 def get_show_headers():
-    return getattr(settings, "DEVBAR_SHOW_HEADERS", False)
+    return get_config()["SHOW_HEADERS"]

tests/settings.py

@@ -1,2 +1,4 @@
-DEVBAR_SHOW_BAR = True
-DEVBAR_SHOW_HEADERS = True
+DEVBAR = {
+    "SHOW_BAR": True,
+    "SHOW_HEADERS": True,
+}

tests/test_middleware.py

@@ -55,7 +55,7 @@ def get_response(request):
         assert b"django-devbar" not in response.content
 
     def test_position_setting(self, rf, settings):
-        settings.DEVBAR_POSITION = "top-left"
+        settings.DEVBAR = {"POSITION": "top-left", "SHOW_BAR": True}
 
         def get_response(request):
             return HttpResponse(
@@ -98,7 +98,7 @@ def get_response(request):
         assert devbar_idx > first_body_idx
 
     def test_devbar_hidden_when_disabled(self, rf, settings):
-        settings.DEVBAR_SHOW_BAR = False
+        settings.DEVBAR = {"SHOW_BAR": False}
 
         def get_response(request):
             return HttpResponse(
@@ -127,7 +127,7 @@ def get_response(request):
         assert "DevBar-Duplicates" not in response
 
     def test_headers_hidden_when_disabled(self, rf, settings):
-        settings.DEVBAR_SHOW_HEADERS = False
+        settings.DEVBAR = {"SHOW_HEADERS": False}
 
         def get_response(request):
             return HttpResponse(