-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set a display name coming from a env var in the title tag and in the page header #3515
Comments
https://dozzle.dev/guide/hostname Isn't this already done? |
Sorry, |
And i rollback,
|
What would you expect it to do? |
${CLUSTER_NAME) is the generic name of the cluster What i hope to see on the header and title is dcltst01, That's why i think that a DISPLAY_NAME var will be a good feature. best regards |
You would have to use
However, I don't think this is possible now. Because is swarm mode, each node is hit at random. So the header will change on every page load. I am not sure what the solution would be. Sorry. If you see something easy, then send a PR. |
I'll check that. |
HI, i come back to you. where did you fill the effective data in config array that you use in title.ts
if I set the default value for config it works, but dynamically not If you have any idea it will be great |
I think you are going down the wrong path. I am still not sure what you are doing or want here. Are you just trying to make it so that the chosen host is in the title? If so, Maybe once I see the PR it will make more sense. |
I just add an DOZZLE_SWARMTITLE var loaded on all node, and the put it in title and in the navbar if hostname is not set. i'll made some test tomorrow and i PR it best regards |
I think I know what you are trying to do. Perhaps you should use I'll most likely ask for that in the PR :) No reason to introduce yet another var that does the same thing as something that already exists. |
There reason Line 174 in 5766410
In Swarm, agents are created on all node. It should probably not take |
Easy enough to do on my side |
It's merged, but I probably won't release until next week when there are a few more fixes to apply. |
I've seem the merge.
For the moment I run with my dev release.
This is a real nice job, a little bit complicate to dive in.
But that's why i love the challenge.
Best regards.
Ph. Koenig / UnclePhil
Le ven. 10 janv. 2025, 17:59, Amir Raminfar ***@***.***> a
écrit :
… It's merged, but I probably won't release until next week when there are a
few more fixes to apply.
—
Reply to this email directly, view it on GitHub
<#3515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADTDE34JBYSUSEWNLG2RKT2J735ZAVCNFSM6AAAAABUXSMPAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBTGI3DMNZZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Describe the feature you would like to see
I use Dozzle on 16 swarm clusters, and sometimes I've 4 or 5 instances open in the same browser with all difficulties to find the good one.
It will be fine to have a Env var with a display name appearing in the title tag and in the header of the application.
BTW your app is a killer one.
best regards
Describe how you would like to see this feature implemented
Describe any alternatives you've considered
No response
The text was updated successfully, but these errors were encountered: