Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-redirect to new container broken #3123

Closed
1 task done
FrancYescO opened this issue Jul 19, 2024 · 6 comments · Fixed by #3129
Closed
1 task done

auto-redirect to new container broken #3123

FrancYescO opened this issue Jul 19, 2024 · 6 comments · Fixed by #3129
Labels
bug Something isn't working

Comments

@FrancYescO
Copy link

FrancYescO commented Jul 19, 2024

🔍 Check for existing issues

  • Completed

How is Dozzle deployed?

Standalone Deployment

📦 Dozzle version

8.0.5

✅ Command used to run Dozzle

README

🐛 Describe the bug / provide steps to reproduce it

this seems was broken with #3098, suggested a solution #3077 (comment) this will also touch this issue #3036

recreate a container, you will not be redirected and will end up to a page saying "no container found" despite the option "auto-redirect to new container w/matching name"

💻 Environment

📸 If applicable, add screenshots to help explain your bug

No response

📜 If applicable, attach your Dozzle logs. You many need to enable debug mode. See https://dozzle.dev/guide/debugging.

No response

@FrancYescO FrancYescO added the bug Something isn't working label Jul 19, 2024
@amir20
Copy link
Owner

amir20 commented Jul 19, 2024

recreate a container, you will not be redirected and will end up to a page saying "no container found" despite the option "auto-redirect to new container w/matching name"

Is the container removed too in this case? Can you tell me which commands are being run? eg. docker stop or docker rm

@amir20
Copy link
Owner

amir20 commented Jul 19, 2024

Ah I see what you mean now. If the container is removed then the page disappears.

I was testing with docker run --rm --name FOO ....

I'll have to think about how to do it better. 🤔

@amir20
Copy link
Owner

amir20 commented Jul 19, 2024

This is going to be tricky because the menu on the left is closely related container view.

@FrancYescO
Copy link
Author

i think that if instead of triggering instantly the delete of the container when you get the message from eventstream show an alert message like "container deleted going to remove" and put a timeout a little bigger of the redirect one to new container one will be enought to get all working as it was

@amir20
Copy link
Owner

amir20 commented Jul 19, 2024

I think I have a better idea. I just need to do a soft delete so the container is still there but the menu hides it.

@amir20
Copy link
Owner

amir20 commented Jul 20, 2024

Should be fixed in master now. Give it a try.

renovate bot referenced this issue in NorkzYT/Wolflith Jul 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | Pending |
|---|---|---|---|
| [amir20/dozzle](https://togithub.com/amir20/dozzle) | patch | `v8.0.5`
-> `v8.0.6` | `v8.0.7` |

---

### Release Notes

<details>
<summary>amir20/dozzle (amir20/dozzle)</summary>

### [`v8.0.6`](https://togithub.com/amir20/dozzle/releases/tag/v8.0.6)

[Compare
Source](https://togithub.com/amir20/dozzle/compare/v8.0.5...v8.0.6)

#####    🚀 Features

- Auto links url for simple logs. fixes
[#&#8203;3063](https://togithub.com/amir20/dozzle/issues/3063)  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3100](https://togithub.com/amir20/dozzle/issues/3100)
and
[https://github.com/amir20/dozzle/issues/3063](https://togithub.com/amir20/dozzle/issues/3063)
[<samp>(3541c)</samp>](https://togithub.com/amir20/dozzle/commit/3541c326)

#####    🐞 Bug Fixes

- Fixes broken host info for remote hosts. fixes
[#&#8203;3103](https://togithub.com/amir20/dozzle/issues/3103)  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3103](https://togithub.com/amir20/dozzle/issues/3103)
[<samp>(6c153)</samp>](https://togithub.com/amir20/dozzle/commit/6c153051)
- Uses correct int size for memory  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3115](https://togithub.com/amir20/dozzle/issues/3115)
[<samp>(01afa)</samp>](https://togithub.com/amir20/dozzle/commit/01afadd4)
- Fixes broken auto redirect. see
[#&#8203;3123](https://togithub.com/amir20/dozzle/issues/3123)  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3129](https://togithub.com/amir20/dozzle/issues/3129)
and
[https://github.com/amir20/dozzle/issues/3123](https://togithub.com/amir20/dozzle/issues/3123)
[<samp>(aa655)</samp>](https://togithub.com/amir20/dozzle/commit/aa6556be)
- Fetching more should only allow for one and abort if one is already in
progress. fixes
[#&#8203;3113](https://togithub.com/amir20/dozzle/issues/3113)  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3118](https://togithub.com/amir20/dozzle/issues/3118)
and
[https://github.com/amir20/dozzle/issues/3113](https://togithub.com/amir20/dozzle/issues/3113)
[<samp>(5d901)</samp>](https://togithub.com/amir20/dozzle/commit/5d9017be)
-   **deps**:
- Update all non-major dependencies  -  by
[@&#8203;renovate](https://togithub.com/renovate)\[bot]
in[https://github.com/amir20/dozzle/issues/3106](https://togithub.com/amir20/dozzle/issues/3106)6
[<samp>(8fec4)</samp>](https://togithub.com/amir20/dozzle/commit/8fec4346)
- Update all non-major dependencies  -  by
[@&#8203;renovate](https://togithub.com/renovate)\[bot]
in[https://github.com/amir20/dozzle/issues/3111](https://togithub.com/amir20/dozzle/issues/3111)1
[<samp>(c5e3f)</samp>](https://togithub.com/amir20/dozzle/commit/c5e3fbcd)
- Update all non-major dependencies  -  by
[@&#8203;renovate](https://togithub.com/renovate)\[bot]
in[https://github.com/amir20/dozzle/issues/3112](https://togithub.com/amir20/dozzle/issues/3112)2
[<samp>(59e0b)</samp>](https://togithub.com/amir20/dozzle/commit/59e0b51c)
- Update dependency tailwindcss to ^3.4.5  -  by
[@&#8203;renovate](https://togithub.com/renovate)\[bot]
in[https://github.com/amir20/dozzle/issues/3117](https://togithub.com/amir20/dozzle/issues/3117)7
[<samp>(987c0)</samp>](https://togithub.com/amir20/dozzle/commit/987c0e6c)
- Update dependency
[@&#8203;iconify-json/material-symbols](https://togithub.com/iconify-json/material-symbols)
to ^1.1.85  -  by
[@&#8203;renovate](https://togithub.com/renovate)\[bot]
in[https://github.com/amir20/dozzle/issues/3121](https://togithub.com/amir20/dozzle/issues/3121)1
[<samp>(565bf)</samp>](https://togithub.com/amir20/dozzle/commit/565bfa30)

#####     [View changes on
GitHub](https://togithub.com/amir20/dozzle/compare/v8.0.5...v8.0.6)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone America/New_York,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/NorkzYT/Wolflith).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoic3RhZ2luZyIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJtaW5vciIsInJlbm92YXRlIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants