You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd expect there to be an option called OPT_GCC_WARNINGS with that given value (and a user default of "-WBaz" based on the lack of developer options being enabled).
If I invoke it without the OPT_GCC_WARNINGS on the command line, I would expect there to be no option available (based on the cmake_dependent_option use in DynamicProjectOptions), but that a hidden one be populated with the value "-WBaz". Instead, I find an option called OPT_GCC_WARNINGS that has the value OFF.
I suspect that either I misunderstand how to use this tool properly, or that this worked at one point but some subtle CMake variable creation behavior changed recently and broke it (and maybe I'm the only one to use this dynamic macro?).
I'm happy to help test this out further. I was hoping to just submit a PR, but I'm really stuck on this so I don't have a solution yet.
Upvote & Fund
I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.
The text was updated successfully, but these errors were encountered:
In short, there cmake_dependent_option sets the option to a BOOL if the guard list (ENABLE_DEVELOPER_MODE in this case) is set. This means that if developer mode is on, this effectively just turns the option into a bool, not defaulting it to the developer default. If the guard is false, then this works just fine.
I'm frankly not sure if cmake_dependent_option is the way to go here, vs. a regular option defaulting to the selecting default based on the mode.
Either something is fundamentally broken with dynamic_project_options or I'm sorely misunderstanding how to use it.
My understanding of the intent is as follows:
OPT_${option_name}
that is configurable afterward running CMake (e.g. throughccmake
).OPT_${option_name}
if it is specified (usually through the cmake command line).ENABLE_DEVELOPER_MODE
is toggled.What am I seeing in the error?
This is the sample CMake file I used, which is just a slightly modified version of the example one in the dynamic project options file.
CMakeLists.txt
If I invoke it like this:
cmake -S . -B ./build -G Ninja -DOPT_GCC_WARNINGS="-Wdouble-conversion"
I'd expect there to be an option called
OPT_GCC_WARNINGS
with that given value (and a user default of"-WBaz"
based on the lack of developer options being enabled).If I invoke it without the
OPT_GCC_WARNINGS
on the command line, I would expect there to be no option available (based on the cmake_dependent_option use in DynamicProjectOptions), but that a hidden one be populated with the value"-WBaz"
. Instead, I find an option calledOPT_GCC_WARNINGS
that has the valueOFF
.I suspect that either I misunderstand how to use this tool properly, or that this worked at one point but some subtle CMake variable creation behavior changed recently and broke it (and maybe I'm the only one to use this dynamic macro?).
I'm happy to help test this out further. I was hoping to just submit a PR, but I'm really stuck on this so I don't have a solution yet.
Upvote & Fund
I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.
The text was updated successfully, but these errors were encountered: