Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Blacklist & Add to Whitelist #1

Open
amiantos opened this issue May 18, 2020 · 5 comments
Open

Add to Blacklist & Add to Whitelist #1

amiantos opened this issue May 18, 2020 · 5 comments
Labels
enhancement New feature or request feedback wanted Feedback is requested from the community iOS Issue pertains to iOS version of PiBar macOS Issue pertains to macOS version of PiBar

Comments

@amiantos
Copy link
Owner

amiantos commented May 18, 2020

  • would be nice if you could add domains to the black list, or add domains to the white list from the toolbar app.
    • would be extra nice if this feature had an interface that showed you some recently accessed or blocked domains to choose from (or lets you input your own)
@amiantos amiantos added the enhancement New feature or request label May 18, 2020
@amiantos
Copy link
Owner Author

For users who have multiple pi-holes: should this feature add the domain to the blacklist/whitelist on all pi-holes? I figure the answer is yes but I would like to get some feedback.

@amiantos amiantos added the feedback wanted Feedback is requested from the community label May 20, 2020
@amiantos amiantos added this to the Version 2.0 milestone May 20, 2020
@Coder84619
Copy link

Yes, if multiple Pi-Holes add to all of them.

@CodeCooler
Copy link

Not to make things more complicated than they need to be, but it seems this functionality could also be implemented as a Safari extension, eliminating the need to leave the browser when an unwanted block is encountered (If I'm not mistaken, Chrome and Safari already have similar extensions available to directly address pi-hole APIs, so this could fill a nice need for Safari users).

@amiantos
Copy link
Owner Author

Technically using the menu bar app isn't really "leaving the browser"? Either way, Browser extensions are kinda outside my wheelhouse, and aren't available on iOS. So it's better all around if I build the functionality into the PiBar core so it can be used by all the clients I make. (Not that it's even a possibility at the moment.)

@CodeCooler
Copy link

Technically using the menu bar app isn't really "leaving the browser"? Either way, Browser extensions are kinda outside my wheelhouse, and aren't available on iOS. So it's better all around if I build the functionality into the PiBar core so it can be used by all the clients I make.

True enough. And Safari extension implementation is way more complicated than it needs to be, but figured I'd throw it out there.

@amiantos amiantos added macOS Issue pertains to macOS version of PiBar iOS Issue pertains to iOS version of PiBar labels Jun 4, 2020
@amiantos amiantos removed this from the macOS 2.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback wanted Feedback is requested from the community iOS Issue pertains to iOS version of PiBar macOS Issue pertains to macOS version of PiBar
Projects
None yet
Development

No branches or pull requests

3 participants