Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to amaranth 0.4 #62

Closed
1 of 3 tasks
jfng opened this issue Dec 11, 2023 · 1 comment
Closed
1 of 3 tasks

Update to amaranth 0.4 #62

jfng opened this issue Dec 11, 2023 · 1 comment

Comments

@jfng
Copy link
Member

jfng commented Dec 11, 2023 •
edited
Loading

@jfng jfng added the bug label Dec 11, 2023
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 12, 2023
@jfng
Update to follow RFCs 37 and 38.
737673b 
Memory maps are now assigned to {csr,wisbhone}.Interface objects instead of
their Signature (which can no longer hold mutable state), as things were
before 9ffaf94.

See amaranth-lang#62.
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 12, 2023
@jfng
Update to follow RFCs 37 and 38.
2e80cd9 
Memory maps are now assigned to {csr,wishbone}.Interface objects instead of
their Signature (which can no longer hold mutable state), as things were
before 9ffaf94.

See amaranth-lang#62.
jfng added a commit to jfng/amaranth-soc that referenced this issue Dec 12, 2023
@jfng
Update to follow RFCs 37 and 38.
4e6e607 
Memory maps and event maps are now assigned to Interface objects instead of
Signature objects (which can no longer hold mutable state), as things were
before 9ffaf94.

See amaranth-lang#62.
@jfng jfng mentioned this issue Dec 12, 2023
Merged
@jfng jfng removed the bug label Dec 12, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2023
@jfng
Update to follow RFCs 37 and 38.
622c7ac 
Memory maps and event maps are now assigned to Interface objects instead of
Signature objects (which can no longer hold mutable state), as things were
before 9ffaf94.

See #62.
@jfng
Copy link
Member Author

jfng commented Dec 13, 2023

  • set requirement to "amaranth>=0.4<0.6"
  • add CI tests against 0.4

Doing this won't help us, as upcoming work (such as #58) depends on upstream functionality that isn't part of the 0.4 release.

@jfng jfng closed this as completed Dec 13, 2023
@jfng jfng mentioned this issue Dec 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfng