Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders not translatable #177

Open
iemand002 opened this issue May 8, 2018 · 3 comments
Open

Placeholders not translatable #177

iemand002 opened this issue May 8, 2018 · 3 comments

Comments

@iemand002
Copy link

Hi

I'm working on a multilang website and using this plugin to create the forms. Now I'm building the frontend I found out that the placeholders aren't translating like the labels do. Checked the plugin and it looks like a simple fix by adding the translate filter:

// templates/_display/templates/_includes/forms/text.html
// line 29
{%- if placeholder is defined %} placeholder="{{ placeholder | t }}"{% endif %}

Can you please add this, also for templates/_display/templates/_includes/forms/textarea.html?

@iemand002
Copy link
Author

Also, please tag the new version so installing with composer works 😉

@iemand002
Copy link
Author

@hubertprein ?

@hubertprein
Copy link
Contributor

We're swamped with work at the moment. For the time being if you could fix it easily feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants