Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markets - Update schema and parsers #94

Open
2 of 8 tasks
arboleya opened this issue Jun 8, 2022 · 4 comments
Open
2 of 8 tasks

Markets - Update schema and parsers #94

arboleya opened this issue Jun 8, 2022 · 4 comments
Assignees
Labels
enh New feature or request

Comments

@arboleya
Copy link
Contributor

arboleya commented Jun 8, 2022

We need to add to new properties on the market schema:

  • minTradeAmount (*)
  • maxTradeAmount

(*) This one exists inside the market.instrument sub-schema, from which it should be removed.

These properties will require minor parsing adjustments on the market parser for all exchanges:

  • Bitfinex
  • Bitmex
  • Bittrex
  • Binance
  • Gate
  • Poloniex
  • Valr
  • FTX

The ongoing PRs for OKX and Huobi must also implement this.

cc @LucianoPierdona

@arboleya arboleya added the enh New feature or request label Jun 8, 2022
@arboleya
Copy link
Contributor Author

arboleya commented Jun 8, 2022

@Torres-ssf Do you see any complications regarding this issue?

@Torres-ssf
Copy link
Contributor

@arboleya I reckon these props should be optional, I'm almost sure not all exchanges are providing this info

@arboleya

This comment was marked as off-topic.

@arboleya

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants