Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanges - Implement Missing Wallets #90

Open
10 tasks
arboleya opened this issue Jun 3, 2022 · 1 comment
Open
10 tasks

Exchanges - Implement Missing Wallets #90

arboleya opened this issue Jun 3, 2022 · 1 comment
Assignees
Labels
enh New feature or request

Comments

@arboleya
Copy link
Contributor

arboleya commented Jun 3, 2022

Intro

We need to consider balances from all wallets, on the balance.list method. The method should return all balances combined in a single list, as it already does — the only difference is that it must include all wallets of a given exchange.

It doesn't matter if we don't support the related account type; we still want to gather balances from all available sources.

Exchanges

Please, review and implement this for all exchanges.

Implementation order:

  • Binance
  • Readme
  • Bitfinex
  • Bitmex
  • Poloniex
  • Bittrex
  • Valr
  • Gate
  • OKX
  • Huobi

TODO

We also need to update all exchange's READMEs — add a new table after "Features".

If a given Wallet doesn't connect to any account, we simply use a hyphen for the account column.

See example below:

readme

@arboleya arboleya added the enh New feature or request label Jun 3, 2022
@arboleya
Copy link
Contributor Author

arboleya commented Jun 3, 2022

So, @Torres-ssf brought up that some exchanges have what could be considered sub-wallets, f.e. multiple wallets for [multiple] derivatives account types and sub-types.

In this case, perhaps we could start prefixing instead of sub-typing?

It requires further examination, but here's a first thought:

export enum AlunaWalletEnum {
  SPOT = 'spot',
  MARGIN = 'margin',
  DERIVATIVES = 'derivatives',
  DERIVATIVES_COIN_M = 'derivatives-coin-m'', // <———————— here
  DERIVATIVES_USD_M = 'derivatives-usd-m'', // <———————— here
  FUNDING = 'funding',
  TRADING = 'trading',
  DEFAULT = 'default',
  WEB3 = 'web3',
}

@arboleya arboleya changed the title Exchanges - Implements Missing Wallets Exchanges - Implement Missing Wallets Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants