db hint

[vitaly-t]

https://github.com/Cadasta/ZipStream/blob/3b95b03cb92fe0362b7900c4c7b86f8929030404/src/backends/db/postgres/index.js#L40

if you just use oneOrNone instead of one, you won't need to do this kind of error handling, just check for null ;)

[alukach]

@vitaly-t Wow, what great OSS support! Thanks for the tip, so to make sure that understand you correctly, oneOrNone wouldn't throw an error so I would need to check for null in a followup .then, right? Something like:

  formatError(err) {  // eslint-disable-line class-methods-use-this
    throw new APIError(err.message, 500);
  }

  checkForEmpty(val) {
    if (val === null) throw new APIError(err.message, 404);
    return val
  }

  update(val) {
    return this.db.oneOrNone(this.cmds.update, val)
      .then(checkForEmpty) 
      .catch(this.formatError);
  }

ps. Loving pg-promise, great library! 👏

[vitaly-t]

yes, that's correct.